Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Billing/pm 11728/wip #4756

Closed
wants to merge 2 commits into from
Closed

Billing/pm 11728/wip #4756

wants to merge 2 commits into from

Conversation

amorask-bitwarden
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 10.83744% with 181 lines in your changes missing coverage. Please review.

Project coverage is 41.72%. Comparing base (4f874ff) to head (3c85494).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ices/Implementations/OrganizationBillingService.cs 0.00% 67 Missing ⚠️
.../Billing/Models/Sales/BitwardenOrganizationSale.cs 0.00% 66 Missing ⚠️
src/Core/Billing/Models/TaxInformation.cs 0.00% 15 Missing ⚠️
...ling/Services/Implementations/SubscriberService.cs 21.42% 9 Missing and 2 partials ⚠️
src/Core/Billing/Models/Sales/SubscriptionSetup.cs 0.00% 8 Missing ⚠️
...ionSubscriptions/UpgradeOrganizationPlanCommand.cs 66.66% 4 Missing and 1 partial ⚠️
...le/Services/Implementations/OrganizationService.cs 57.14% 2 Missing and 1 partial ⚠️
src/Core/Billing/Models/Sales/CustomerSetup.cs 0.00% 3 Missing ⚠️
...ole/Controllers/ProviderOrganizationsController.cs 0.00% 1 Missing ⚠️
...lling/Controllers/OrganizationBillingController.cs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4756      +/-   ##
==========================================
- Coverage   41.74%   41.72%   -0.03%     
==========================================
  Files        1304     1306       +2     
  Lines       61841    61900      +59     
  Branches     5694     5704      +10     
==========================================
+ Hits        25818    25828      +10     
- Misses      34835    34881      +46     
- Partials     1188     1191       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details – 898f586e-ad6b-4b72-8d05-82bc41d1d37e

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Passwords And Secrets - Generic Password /test-database.yml: 177 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /test-database.yml: 173 Query to find passwords and secrets in infrastructure code.
HIGH Passwords And Secrets - Generic Password /test-database.yml: 170 Query to find passwords and secrets in infrastructure code.

Fixed Issues

Severity Issue Source File / Package
HIGH Passwords And Secrets - Generic Password /test-database.yml: 189
HIGH Passwords And Secrets - Generic Password /test-database.yml: 182
HIGH Passwords And Secrets - Generic Password /test-database.yml: 185

@amorask-bitwarden amorask-bitwarden deleted the billing/PM-11728/wip branch September 10, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amorask-bitwarden